hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Karthik K <oss....@gmail.com>
Subject Re: Resource Release Helper methods - HTTPCLIENT-1159
Date Wed, 18 Jan 2012 21:34:14 GMT
On Wed, Jan 18, 2012 at 12:30 PM, Oleg Kalnichevski <olegk@apache.org>wrote:

> On Wed, 2012-01-18 at 11:56 -0800, Karthik K wrote:
> > As part of httpclient development, I find myself writing these helper
> > utilities to release resources ( HttpClient / HttpEntity ) etc , very
> > similar to IOUtils , from commons.io to release resources , that closes
> > 'quietly' .
> >
> >
> > o.a.h.utils.HttpClientUtils
> >   closeQuietly(HttpClient)
> > and closeQuietly(HttpResponse response)
> >
> > https://issues.apache.org/jira/browse/HTTPCLIENT-1159 .
> >
> > + some test cases as well.
> >
> > Let me know your thoughts on the same.
> >
> > --
> >   Karthik.
>
> I'll happily commit the patch to SVN trunk if no objections are raised
> within a day or two. One minor issue is that the proposed patch makes
> use of static Log instances that generally are to be avoided. Otherwise
> the patch looks good to me.
>
> Cheers
>
> Oleg
>
>
Thanks, Oleg.

I have attached a version that has no logging at all altogether.

My $0.02 -  given that this is independent with backward compatibility
still, would it be possible to backport this to 4.1.x releases , to help
incorporate this in our codebases , sooner than later.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message