hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Moore (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1157) MemcachedHttpCacheStorage should throw IOExceptions instead of Runtime Exceptions
Date Wed, 11 Jan 2012 18:15:38 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13184250#comment-13184250
] 

Jon Moore commented on HTTPCLIENT-1157:
---------------------------------------

@James: patch committed to trunk. I also wrapped try...catch around the cache puts and cache
deletes as well for completeness. Please take a look, and if that works for you I'll also
backport to 4.1.x. Many thanks for this!

                
> MemcachedHttpCacheStorage should throw IOExceptions instead of Runtime Exceptions
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1157
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1157
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.2 Alpha1
>            Reporter: James Miller
>            Assignee: Jon Moore
>              Labels: cache
>             Fix For: 4.1.3, 4.2 Alpha2
>
>         Attachments: HTTPCLIENT-1157.patch, httpclient-1157-2.patch
>
>
> The MemcachedHttpCacheStorage class implements HttpCacheStorage which defines that methods
will throw IOExceptions, but the underlying net.spy.memcached.MemcachedClientIF throws runtime
exceptions. These exceptions are not caught in the code where IOExceptions are expected causing
these exception bubble up to the calling code. It seems like the MemcachedHttpCacheStorage
class should treat at least some of these runtime exceptions as IOExceptions so that normal
code execution paths can be followed.  
> I'm proposing that MemcachedHttpCacheStorage treat a OperationTimeoutException from the
memcached client as an IOException. This would allow the existing CachingHttpClient code to
catch and log the exception as a warning, instead of bubbling the exception up the calling
code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message