hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1161) httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to StringBuffer
Date Tue, 31 Jan 2012 00:25:10 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196571#comment-13196571
] 

Sebb commented on HTTPCLIENT-1161:
----------------------------------

We something similar in Commons (Lang, I think) and hit some problems.

One is that the Appendable interface throws IOException; cannot remember off-hand what (if
any) other issues were found.

It may not be as simple as replacing the parameter type.

Also, changing a parameter type is not binary compatible, so we would need to keep the existing
method at least for now.
                
> httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to
StringBuffer 
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1161
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1161
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.2 Alpha1
>            Reporter: Karthik K
>            Priority: Minor
>             Fix For: 4.2 Final
>
>         Attachments: HTTPCLIENT-1161.patch
>
>
> Current signature, reads: 
> org/apache/http/impl/client/cache/RequestEquivalent.java: 
> public void appendTo(StringBuffer buf) {
> Replace the signature with Appendable, to make it more generic and not tied to StringBuffer.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message