hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Moore (Closed) (JIRA)" <j...@apache.org>
Subject [jira] [Closed] (HTTPCLIENT-1161) httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to StringBuffer
Date Tue, 31 Jan 2012 14:10:10 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Jon Moore closed HTTPCLIENT-1161.

    Resolution: Invalid
      Assignee: Jon Moore

This method is part of the IArgumentMatcher interface from EasyMock: 

Therefore, we're not able to make this change even if we wanted to.

Furthermore, this is a test class supporting the various unit tests in httpclient-cache, and
hence not a part of the public API. I am in general a subscriber to YAGNI (You Ain't Gonna
Need It) and resist premature generalization, particularly of test classes that are project-internal.

> httpclient-cache: RequestEquivalent # appendTo : make it take Appendable as opposed to
> ----------------------------------------------------------------------------------------------------
>                 Key: HTTPCLIENT-1161
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1161
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>    Affects Versions: 4.2 Alpha1
>            Reporter: Karthik K
>            Assignee: Jon Moore
>            Priority: Minor
>             Fix For: 4.2 Final
>         Attachments: HTTPCLIENT-1161.patch
> Current signature, reads: 
> org/apache/http/impl/client/cache/RequestEquivalent.java: 
> public void appendTo(StringBuffer buf) {
> Replace the signature with Appendable, to make it more generic and not tied to StringBuffer.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message