hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Resource Release Helper methods - HTTPCLIENT-1159
Date Wed, 18 Jan 2012 20:30:29 GMT
On Wed, 2012-01-18 at 11:56 -0800, Karthik K wrote:
> As part of httpclient development, I find myself writing these helper
> utilities to release resources ( HttpClient / HttpEntity ) etc , very
> similar to IOUtils , from commons.io to release resources , that closes
> 'quietly' .
> 
> 
> o.a.h.utils.HttpClientUtils
>   closeQuietly(HttpClient)
> and closeQuietly(HttpResponse response)
> 
> https://issues.apache.org/jira/browse/HTTPCLIENT-1159 .
> 
> + some test cases as well.
> 
> Let me know your thoughts on the same.
> 
> --
>   Karthik.

I'll happily commit the patch to SVN trunk if no objections are raised
within a day or two. One minor issue is that the proposed patch makes
use of static Log instances that generally are to be avoided. Otherwise
the patch looks good to me.

Cheers

Oleg 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message