hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "James Miller (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HTTPCLIENT-1157) MemcachedHttpCacheStorage should throw IOExceptions instead of Runtime Exceptions
Date Thu, 05 Jan 2012 21:54:39 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

James Miller updated HTTPCLIENT-1157:
-------------------------------------

    Attachment: HTTPCLIENT-1157.patch

Here is a patch wrapping the OperationTimeoutException as an IOException so that the normal
code path can be followed.
                
> MemcachedHttpCacheStorage should throw IOExceptions instead of Runtime Exceptions
> ---------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1157
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1157
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.2 Alpha1
>            Reporter: James Miller
>              Labels: cache
>         Attachments: HTTPCLIENT-1157.patch
>
>
> The MemcachedHttpCacheStorage class implements HttpCacheStorage which defines that methods
will throw IOExceptions, but the underlying net.spy.memcached.MemcachedClientIF throws runtime
exceptions. These exceptions are not caught in the code where IOExceptions are expected causing
these exception bubble up to the calling code. It seems like the MemcachedHttpCacheStorage
class should treat at least some of these runtime exceptions as IOExceptions so that normal
code execution paths can be followed.  
> I'm proposing that MemcachedHttpCacheStorage treat a OperationTimeoutException from the
memcached client as an IOException. This would allow the existing CachingHttpClient code to
catch and log the exception as a warning, instead of bubbling the exception up the calling
code.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message