hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (Resolved) (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (HTTPCLIENT-1120) DefaultHttpRequestRetryHandler#retryRequest should not retry aborted requests
Date Thu, 06 Oct 2011 12:42:29 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-1120.
-------------------------------------------

    Resolution: Fixed

* Moved all test cases for abort handling to TestAbortHandling
* AbstractPoolEntry now throws InterruptedIOException instead of plain IOException
* Applied a variation of the patch contributed by Alin
* Merged fixes to 4.1.x branch

Oleg
                
> DefaultHttpRequestRetryHandler#retryRequest should not retry aborted requests
> -----------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1120
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1120
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.1.2
>            Reporter: Sebb
>             Fix For: 4.1.3, 4.2 Alpha1
>
>         Attachments: no_request_in_context.patch, patch.diff, req_abort_test.patch, retry_handler.patch
>
>
> DefaultHttpRequestRetryHandler#retryRequest incorrectly retries aborted requests; I have
seen the following log messages in JMeter:
> org.apache.http.impl.client.DefaultHttpClient: I/O exception (java.net.SocketException)
caught when processing request: socket closed
> org.apache.http.impl.client.DefaultHttpClient: Retrying request
> and
> org.apache.http.impl.client.DefaultHttpClient: I/O exception (java.net.BindException)
caught when connecting to the target host: Address already in use: connect
> org.apache.http.impl.client.DefaultHttpClient: Retrying connect
> The abort() method sets the isAborted() flag, but the retry handler does not check it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message