hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: svn commit: r1179609
Date Thu, 06 Oct 2011 18:25:01 GMT
On Thu, 2011-10-06 at 17:05 +0100, sebb wrote:
> On 6 October 2011 14:07,  <olegk@apache.org> wrote:
> > Author: olegk
> > Date: Thu Oct  6 13:07:33 2011
> > New Revision: 1179609
> >
> > URL: http://svn.apache.org/viewvc?rev=1179609&view=rev
> > Log:
> > HTTPCLIENT-1127: fixed dead-lock between SingleClientConnManager and AbstractPooledConnAdapter
> >
> > Modified:
> >    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/AbstractClientConnAdapter.java
> >    httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/AbstractPooledConnAdapter.java
> >
> > Modified: httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/AbstractClientConnAdapter.java
> > URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/AbstractClientConnAdapter.java?rev=1179609&r1=1179608&r2=1179609&view=diff
> > ==============================================================================
> > --- httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/AbstractClientConnAdapter.java
(original)
> > +++ httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/conn/AbstractClientConnAdapter.java
Thu Oct  6 13:07:33 2011
> > @@ -78,7 +78,7 @@ public abstract class AbstractClientConn
> >      * This attribute MUST NOT be final, so the adapter can be detached
> >      * from the connection manager without keeping a hard reference there.
> >      */
> > -    private volatile ClientConnectionManager connManager;
> > +    private final ClientConnectionManager connManager;
> >
> 
> Does the comment about not using final no longer apply?
> If so, then the comment should be removed or fixed to avoid confusion later.

Comment removed.

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message