hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1120) DefaultHttpRequestRetryHandler#retryRequest should not retry aborted requests
Date Tue, 27 Sep 2011 15:04:11 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115554#comment-13115554
] 

Sebb commented on HTTPCLIENT-1120:
----------------------------------

Testing with JMeter shows that when an aborted request fails in the connect phase, the request
is not present in the context.

Further, if the request is added to the context (under a new key) for debug purposes, the
aborted flag is not set.

The combination BindException/"Address already in use: connect" is the exception generated
(or at least the commonest).
                
> DefaultHttpRequestRetryHandler#retryRequest should not retry aborted requests
> -----------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1120
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1120
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.1.2
>            Reporter: Sebb
>             Fix For: 4.1.3, 4.2 Alpha1
>
>         Attachments: patch.diff
>
>
> DefaultHttpRequestRetryHandler#retryRequest incorrectly retries aborted requests; I have
seen the following log messages in JMeter:
> org.apache.http.impl.client.DefaultHttpClient: I/O exception (java.net.SocketException)
caught when processing request: socket closed
> org.apache.http.impl.client.DefaultHttpClient: Retrying request
> and
> org.apache.http.impl.client.DefaultHttpClient: I/O exception (java.net.BindException)
caught when connecting to the target host: Address already in use: connect
> org.apache.http.impl.client.DefaultHttpClient: Retrying connect
> The abort() method sets the isAborted() flag, but the retry handler does not check it.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message