hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael Pujos (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1122) NPE in RequestProxyAuthentication on Android
Date Tue, 06 Sep 2011 09:18:11 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097828#comment-13097828
] 

Michael Pujos commented on HTTPCLIENT-1122:
-------------------------------------------

Now that I think of it, the app code related to the stack trace above does indeed have plenty
of HttpRequest.abort() going on while the request is executing. 
I'd say it has more aborting than usual, since requests are made to download thumbnails images
in a list, and requests are aborted during scrolling when previously visible list item are
now invisible.

> NPE in RequestProxyAuthentication on Android
> --------------------------------------------
>
>                 Key: HTTPCLIENT-1122
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1122
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.1.1
>         Environment: Android 2.3.4. Using repackaged httpcore 4.1.1 in an app obfuscated
with Proguard.
> must be very rare as I only saw it once for > 10K users.
>            Reporter: Michael Pujos
>            Priority: Minor
>             Fix For: 4.2 Alpha1
>
>
> Got a NPE backtrace in RequestProxyAuthentication.process(). 
> HttpRoute route = conn.getRoute();
>         if (route.isTunnelled()) {      <= line 88, NPE here
>             return;
>         }
> There's no null check on the returned route although getRoute() can return null.
> I guess it's not supposed to happen.
> In the httpclient code, there's a few more calls to getRoute() without a null check on
the returned route.
> java.lang.NullPointerException
> at com.bubblesoft.org.apache.http.client.protocol.RequestProxyAuthentication.process(SourceFile:88)
> at com.bubblesoft.org.apache.http.protocol.ImmutableHttpProcessor.process(SourceFile:108)
> at com.bubblesoft.org.apache.http.protocol.HttpRequestExecutor.preProcess(SourceFile:174)
> at com.bubblesoft.org.apache.http.impl.client.DefaultRequestDirector.execute(SourceFile:457)
> at com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:821)
>                                                                  execute
> at com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:755)
>                                                                  execute
> at com.bubblesoft.org.apache.http.impl.client.AbstractHttpClient.createHttpProcessor(SourceFile:733)
>                                                                  execute

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message