hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thomas Boettcher (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HTTPCLIENT-1098) Populating exception message with InetSocketAddress.getHostName() can take a long time
Date Mon, 06 Jun 2011 16:54:03 GMT
Populating exception message with InetSocketAddress.getHostName() can take a long time
--------------------------------------------------------------------------------------

                 Key: HTTPCLIENT-1098
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1098
             Project: HttpComponents HttpClient
          Issue Type: Improvement
          Components: HttpConn
    Affects Versions: 4.1.1
            Reporter: Thomas Boettcher
         Attachments: exception_message.txt

In the PlainSocketFactory class, when a SocketTimeoutException occurs a call is made to InetSocketAddress.getHostName()
when generating the exception message. Unfortunately, this call can take a long time. In my
case, the address I am specifying is an IP address, which InetSocketAddress attempts to perform
a reverse-lookup on to determine the hostname; however, since  the address does not have a
hostname assigned to it, the operation takes a long time to return.

I'm attaching a patch for trunk with my proposed fix. Viewing the source history, it looks
like the code used to have the behavior I'm proposing, but it was changed in revision 1070943.
Based on the source commits and linked issues, I cannot determine a specific reason for the
change. If there is a reason the code needs to be the way it is, then I apologize for inconvenience
I have caused.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message