Return-Path: X-Original-To: apmail-hc-dev-archive@www.apache.org Delivered-To: apmail-hc-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DBEE15B49 for ; Thu, 12 May 2011 11:28:53 +0000 (UTC) Received: (qmail 59694 invoked by uid 500); 12 May 2011 11:28:53 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 59636 invoked by uid 500); 12 May 2011 11:28:52 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 59627 invoked by uid 99); 12 May 2011 11:28:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 11:28:52 +0000 X-ASF-Spam-Status: No, hits=0.7 required=5.0 tests=SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (nike.apache.org: local policy) Received: from [92.42.190.144] (HELO ok2cons2.nine.ch) (92.42.190.144) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 May 2011 11:28:43 +0000 Received: from [192.168.42.96] (unknown [213.55.131.181]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ok2cons2.nine.ch (Postfix) with ESMTPSA id 6C96E245E41A for ; Thu, 12 May 2011 13:28:22 +0200 (CEST) Subject: Re: Truncated content-length delimited message bodies From: Oleg Kalnichevski To: HttpComponents Project In-Reply-To: <4DCB3D3A.7020407@apache.org> References: <4DCA5B93.7050206@apache.org> <1305116759.14068.4.camel@ubuntu> <4DCAB6F2.5070107@apache.org> <1305142400.26615.4.camel@ubuntu> <4DCB3D3A.7020407@apache.org> Content-Type: text/plain; charset="UTF-8" Date: Thu, 12 May 2011 13:28:13 +0200 Message-ID: <1305199693.17441.6.camel@ubuntu> Mime-Version: 1.0 X-Mailer: Evolution 2.30.3 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org ... > Hi Oleg > > Just saw that you had called off the vote.. I will check the fix once > the changes are committed > Hi Asankha Fixed committed to SVN trunk http://svn.apache.org/viewvc?rev=1102241&view=rev Please review the changes and let me know if you find anything disagreeable. I'll merge the changes to 4.1.x branch as soon as I get an OK from you. > I assume that sometimes the content length does go off from the actual > size in reality by some servers.. Do you think length checking could > cause too many false alarms in such cases? > It is difficult to say. I presume such protocol violations are not that uncommon. On the other hand one can still choose to catch and ignore the I/O exception thrown by the codec and accept partial content as a valid message. Cheers Oleg --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org