hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: svn commit: r1098093
Date Tue, 03 May 2011 19:46:15 GMT
On Tue, 2011-05-03 at 20:39 +0100, sebb wrote:
> On 3 May 2011 20:22, Oleg Kalnichevski <olegk@apache.org> wrote:
> >
> >> I'm not sure I understand why the 4.1.x changes are different from the
> >> trunk changes.
> >>
> >
> > Ideally 0.0.x releases should be fully compatible so one could upgrade /
> > downgrade patch releases without having to recompile and redeploy. That
> > basically means there can be no new methods / classes in 0.0.x releases
> 
> I see.
> 
> I had not realised point releases were supposed to be backwards compatible.
> 

They do not _really_ have to be, but something which I consider worth
having.

> >
> >> Why does ConnManagerParams.getTimeout - above - now return
> >> "http.connection.timeout" if "http.conn-manager.timeout" is not
> >> defined?
> >>
> >
> > This is the only way I could think of to preserve behavioral
> > compatibility with 4.1.0 and 4.1.1 releases
> >
> >> If a default is to be applied, should that not be done in
> >> DefaultRequestDirector instead?
> >>
> >
> > Fair point. I would not bother with the 4.1.x branch but certainly could
> > be done in trunk.
> 
> Even though the fix changes the behaviour of getTimeout() ?
> 

The method is deprecated. And really can't think of any side effects.
Feel free to move that logic to DefaultRequestDirector, though.

Oleg



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message