hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jon Moore (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HTTPCLIENT-1073) cache module generates exceptions for non-compliant responses without consuming response bodies
Date Wed, 23 Mar 2011 13:45:05 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010122#comment-13010122
] 

Jon Moore commented on HTTPCLIENT-1073:
---------------------------------------

Ok, after sleeping on it, I think the fix warrants a little deeper analysis than the patch
I posted. For example, if the origin response is a 401 missing the WWW-Authenticate header,
this is strictly non-compliant, but shouldn't affect the caching module, and a client not
using the caching module would have to deal with this anyway; so this compliance test ought
to be removed. I'll check the other ones -- there are only about 4 unit tests and associated
code.

> cache module generates exceptions for non-compliant responses without consuming response
bodies
> -----------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1073
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1073
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>    Affects Versions: 4.1 Beta1, 4.1 Final, 4.1.1, 4.2 Final
>            Reporter: Jon Moore
>            Assignee: Jon Moore
>         Attachments: 1073.patch
>
>
> In the ResponseProtocolCompliance class, the caching module checks the incoming origin
response to attempt to make it compliant with RFC2616. However, if there are instances where
this is not possible, it currently throws an exception without consuming the origin response
body; this causes a connection leak if the general try..catch..finally pattern documented
on the HttpClient interface Javadoc is followed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message