hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Steffen Yount (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-1044) DefaultHttpRequestRetryHandler is not handling PUT as an idempotent method for retries, though RFC2616 section 9.1.2 clearly defines it to be one.
Date Wed, 09 Feb 2011 00:57:57 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12992259#comment-12992259
] 

Steffen Yount commented on HTTPCLIENT-1044:
-------------------------------------------

It looks like the two implementations will produce identical behaviors.

For the choice of class name I like your name "StandardHttpRequestRetryHandler" better.

Also, I think your choice of positively identifying the idempotent methods rather than checking
for not-a-POST like I did, makes the code much cleaner to read... almost self documenting
:-)

I'm happy with your implementation.

Thank you for spending time on this issue!

While, your extortion does make me feel guilty, and I know I would probably be a better programmer
if I figured out how to integrate with the test framework, I still don't see myself getting
around to writing test cases for this anytime soon... Sorry about that, it's a really busy
quarter for me...

Cheers and thanks again!
-Steffen

> DefaultHttpRequestRetryHandler is not handling PUT as an idempotent method for retries,
though RFC2616 section 9.1.2 clearly defines it to be one.
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1044
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1044
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0.3, 4.1 Final
>            Reporter: Steffen Yount
>            Priority: Minor
>             Fix For: 4.2 Final
>
>         Attachments: HTTPCLIENT-1044.patch, HTTPCLIENT-1044_planB.patch, HTTPCLIENT-1044_planC.patch,
HTTPCLIENT-1044_planC_v2.patch
>
>
> See attached patch file for a fix:
> Fix treats PUT requests as idempotent, marking them to be retried when their enclosed
HttpEntity is either null or repeatable.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message