hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Resolved: (HTTPCLIENT-1044) DefaultHttpRequestRetryHandler is not handling PUT as an idempotent method for retries, though RFC2616 section 9.1.2 clearly defines it to be one.
Date Tue, 08 Feb 2011 21:09:57 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski resolved HTTPCLIENT-1044.
-------------------------------------------

    Resolution: Fixed

Steffen

I ended up committing a slightly different implementation conceptually similar to the one
proposed by you. Please review:

http://svn.apache.org/repos/asf/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/StandardHttpRequestRetryHandler.java

(*shameless extortion*) Also, feel free to contribute test cases

Oleg  

> DefaultHttpRequestRetryHandler is not handling PUT as an idempotent method for retries,
though RFC2616 section 9.1.2 clearly defines it to be one.
> --------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1044
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1044
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0.3, 4.1 Final
>            Reporter: Steffen Yount
>            Priority: Minor
>             Fix For: 4.2 Final
>
>         Attachments: HTTPCLIENT-1044.patch, HTTPCLIENT-1044_planB.patch, HTTPCLIENT-1044_planC.patch,
HTTPCLIENT-1044_planC_v2.patch
>
>
> See attached patch file for a fix:
> Fix treats PUT requests as idempotent, marking them to be retried when their enclosed
HttpEntity is either null or repeatable.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message