hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-1046) Make class SchemeSocketFactoryAdaptor public
Date Tue, 25 Jan 2011 09:58:44 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986305#action_12986305
] 

Oleg Kalnichevski commented on HTTPCLIENT-1046:
-----------------------------------------------

Gary

SchemeSocketFactoryAdaptor really ought not be a part of the public API. It is already complex
enough. You only need to copy a dozen of lines of code at most. 

Oleg

> Make class SchemeSocketFactoryAdaptor public
> --------------------------------------------
>
>                 Key: HTTPCLIENT-1046
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1046
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpConn
>    Affects Versions: 4.1.0
>         Environment: java version "1.6.0_23"
> Java(TM) SE Runtime Environment (build 1.6.0_23-b05)
> Java HotSpot(TM) 64-Bit Server VM (build 19.0-b09, mixed mode)
>            Reporter: Gary Gregory
>
> I am porting code to 4.1 and removing our use of deprecated classes and methods.
> In order to provide backward compatibility I need to support SocketFactory but I want
to store a SchemeSocketFactory in the code.
> This means using an adapter which exists already but is package private: SchemeSocketFactoryAdaptor.
> I am requesting to make SchemeSocketFactoryAdaptor public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message