hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gary Gregory (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-1046) Make class SchemeSocketFactoryAdaptor public
Date Tue, 25 Jan 2011 11:54:43 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986351#action_12986351
] 

Gary Gregory commented on HTTPCLIENT-1046:
------------------------------------------

I understand but that is not a good reason for promoting code duplication IMO. 

The API is made more complicated by deprecating whole classes and leaving people out without
a full migration story. Changing code without a migration guide is bad enough but I would
raise an eyebrow if part of such a guide included 'go copy this code over there'!

This might be part of this price of deprecating APIs. 


> Make class SchemeSocketFactoryAdaptor public
> --------------------------------------------
>
>                 Key: HTTPCLIENT-1046
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1046
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpConn
>    Affects Versions: 4.1 Final
>         Environment: java version "1.6.0_23"
> Java(TM) SE Runtime Environment (build 1.6.0_23-b05)
> Java HotSpot(TM) 64-Bit Server VM (build 19.0-b09, mixed mode)
>            Reporter: Gary Gregory
>
> I am porting code to 4.1 and removing our use of deprecated classes and methods.
> In order to provide backward compatibility I need to support SocketFactory but I want
to store a SchemeSocketFactory in the code.
> This means using an adapter which exists already but is package private: SchemeSocketFactoryAdaptor.
> I am requesting to make SchemeSocketFactoryAdaptor public.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message