hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1053062 - /httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/TestRequestRetryHandler.java
Date Thu, 30 Dec 2010 13:32:57 GMT
On 27 December 2010 13:07,  <jonm@apache.org> wrote:
> Author: jonm
> Date: Mon Dec 27 13:07:53 2010
> New Revision: 1053062
>
> URL: http://svn.apache.org/viewvc?rev=1053062&view=rev
> Log:
> Changed bad host for retry handler tests to bogus.example.com
> from www.complete.garbage.invalid, which seems to have better
> timing properties for me (and hopefully Hudson).
>

bogus.example.com is not guaranteed to be an invalid host name; it may
one day be defined.

The .invalid TLD is the only safe way to ensure that a host name
remains invalid forever.

If the test code does not work well for you with the .invalid TLD,
then that needs to be addressed in a different way.


> Modified:
>    httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/TestRequestRetryHandler.java
>
> Modified: httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/TestRequestRetryHandler.java
> URL: http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/TestRequestRetryHandler.java?rev=1053062&r1=1053061&r2=1053062&view=diff
> ==============================================================================
> --- httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/TestRequestRetryHandler.java
(original)
> +++ httpcomponents/httpclient/trunk/httpclient/src/test/java/org/apache/http/impl/client/TestRequestRetryHandler.java
Mon Dec 27 13:07:53 2010
> @@ -73,7 +73,7 @@ public class TestRequestRetryHandler {
>         TestHttpRequestRetryHandler testRetryHandler = new TestHttpRequestRetryHandler();
>         client.setHttpRequestRetryHandler(testRetryHandler);
>
> -        HttpRequestBase request = new HttpGet("http://www.complete.garbage.invalid");
> +        HttpRequestBase request = new HttpGet("http://bogus.example.com/");
>
>         HttpConnectionParams.setConnectionTimeout(request.getParams(), 1);
>         try {
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message