hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Reopened: (HTTPCLIENT-911) Support underscore in domain name, or provide better exception
Date Mon, 13 Dec 2010 18:56:07 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Sebb reopened HTTPCLIENT-911:
-----------------------------


Current code does not work if there is a colon in the path but no colon in the host part.

This appears to have been caused by the following change:

http://svn.apache.org/viewvc/httpcomponents/httpclient/trunk/httpclient/src/main/java/org/apache/http/impl/client/AbstractHttpClient.java?r1=980937&r2=980936&pathrev=980937

which was presumably intended to improve underscore support?

The method currently has no unit tests - previously it was simple enough not to need them,
but now I think they are needed.

This requires changing the method from private to package-protected - which should not cause
any problems as the method does not change any external fields.


> Support underscore in domain name, or provide better exception
> --------------------------------------------------------------
>
>                 Key: HTTPCLIENT-911
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-911
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>    Affects Versions: 4.0.1
>            Reporter: Ziv Horesh
>            Priority: Minor
>             Fix For: 4.1 Alpha2
>
>         Attachments: HTTPCLIENT-911.patch
>
>
> When calling on HttpClient.execute with a url that contain underscore ('_'), you get
NullPointerException.
> Tracing it down show that java.net.Uri complains that it is illegal name. Which is true
according to the RFC.
> But it seems that most browser allow it, and some companies support it.
> I think HttpClient should either support underscores, or atleast provide a better exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message