hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mohan Rao (JIRA)" <j...@apache.org>
Subject [jira] Created: (HTTPCORE-240) DefaultConnectingIOReactor leaks socket descriptors if connections fail
Date Mon, 01 Nov 2010 21:24:24 GMT
DefaultConnectingIOReactor leaks socket descriptors if connections fail
-----------------------------------------------------------------------

                 Key: HTTPCORE-240
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-240
             Project: HttpComponents HttpCore
          Issue Type: Bug
    Affects Versions: 4.0.1
            Reporter: Mohan Rao


> We are using HttpCore 4.0.1 
> 
> Also in particular in DefaultConnectingIOReactor - 
> 
>  SocketChannel socketChannel; 
>             try { 
>                 socketChannel = SocketChannel.open(); 
>                 socketChannel.configureBlocking(false); 
>             } catch (IOException ex) { 
>                 throw new IOReactorException("Failure opening socket", ex); 
>             } 
>             try { 
>                 validateAddress(request.getLocalAddress()); 
>                 validateAddress(request.getRemoteAddress()); 
>                 
>                 if (request.getLocalAddress() != null) { 
>                     socketChannel.socket().bind(request.getLocalAddress()); 
>                 } 
>                 boolean connected = 
> socketChannel.connect(request.getRemoteAddress()); 
>                 if (connected) { 
>                     prepareSocket(socketChannel.socket()); 
>                     ChannelEntry entry = new ChannelEntry(socketChannel, 
> request); 
>                     addChannel(entry); 
>                     return; 
>                 } 
>             } catch (IOException ex) { 
>                 request.failed(ex); 
>                 return; 
>             } 
> 
> 
> In the above code - should the socketChannel be closed before request.failed 
> is called ? 
> 
« [hide part of quote]

You are right. It should be but it is not. Please raise an issue in JIRA 
for this defect. 

Oleg 



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message