hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-1006) BrowserCompatSpec: don't trim " around cookie value
Date Mon, 04 Oct 2010 10:20:34 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917548#action_12917548
] 

Oleg Kalnichevski commented on HTTPCLIENT-1006:
-----------------------------------------------

> I don't understand why the change proposed here doesn't match in this BrowserCompatSpec

Because the proposed change would create an ambiguity as to what exactly constitutes a cookie
value. The user would need to know whether or not to strip enclosing quotes around cookie
values depending on what cookie spec they have been parsed with, which is not even always
possible. 

Having said all that, should you be willing to contribute a full compatibility IE/Firefox
cookie spec, I would be in favor of including it into HttpClient distribution.

Oleg

> BrowserCompatSpec: don't trim " around cookie value
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1006
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1006
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCookie
>    Affects Versions: 4.0.2
>            Reporter: Marc Guillemot
>
> If the server sends a cookie header like:
> Set-Cookie: first="hello world"
> then HttpClient parses it as cookie with value >hello world<, wrongly removing
the leading and trailing quotes. The incorrect quote removal occurs in BasicHeaderValueParser.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message