hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marc Guillemot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-1006) BrowserCompatSpec: don't trim " around cookie value
Date Mon, 04 Oct 2010 09:52:35 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917538#action_12917538
] 

Marc Guillemot commented on HTTPCLIENT-1006:
--------------------------------------------

Hi Oleg,

I understand that you don't consider reproducing browser craziness as belonging to the focus
of HttpClient. Nevertheless you have a BrowserCompatSpec cookie spec with the description
"Cookie specification that strives to closely mimic (mis)behavior of common web browser applications
such as Microsoft Internet Explorer and Mozilla FireFox. ". I don't understand why the change
proposed here doesn't match in this BrowserCompatSpec.

And yes we adapt HttpClient in different ways to be able to match common browsers behaviour.
Sometimes it is more a hack than and adaptation (for instance our workaround for HTTPCLIENT-960).
I have now added a custom cookie spec but we try to keep customization minimal as we remember
the migration from 3.x to Httpclient-4.

> BrowserCompatSpec: don't trim " around cookie value
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1006
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1006
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCookie
>    Affects Versions: 4.0.2
>            Reporter: Marc Guillemot
>
> If the server sends a cookie header like:
> Set-Cookie: first="hello world"
> then HttpClient parses it as cookie with value >hello world<, wrongly removing
the leading and trailing quotes. The incorrect quote removal occurs in BasicHeaderValueParser.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message