hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Marc Guillemot (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-1006) BrowserCompatSpec: don't trim " around cookie value
Date Mon, 04 Oct 2010 13:13:32 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-1006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12917585#action_12917585
] 

Marc Guillemot commented on HTTPCLIENT-1006:
--------------------------------------------

With "IE/Firefox spec" I meant a single spec reproducing common browsers behavior and therefore
the same as BrowserCompatSpec.

>> Where do the expectations in org.apache.http.impl.cookie.TestBrowserCompatSpec come
from?
> Accumulated over years based on users' feedback and bug reports 

I disagree, at least concerning the quotes issue. If you look for instance at the first test
with quotes: testParse3 is there since the initial commit of TestCookie.java on 05/01/2001
at a time where there were no BrowserCompatSpec. Therefore it is not a test that has been
designed for browser compatibility.

I currently don't see how I could propose a patch that would have a chance to get accepted
as you seem to defend the full correctness of TestBrowserCompatSpec.

> BrowserCompatSpec: don't trim " around cookie value
> ---------------------------------------------------
>
>                 Key: HTTPCLIENT-1006
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1006
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpCookie
>    Affects Versions: 4.0.2
>            Reporter: Marc Guillemot
>
> If the server sends a cookie header like:
> Set-Cookie: first="hello world"
> then HttpClient parses it as cookie with value >hello world<, wrongly removing
the leading and trailing quotes. The incorrect quote removal occurs in BasicHeaderValueParser.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message