hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Any known issues with Http Core NIO and tomcat 5.2.3?
Date Thu, 14 Oct 2010 15:07:48 GMT
On Thu, 2010-10-14 at 20:25 +0530, Asankha C. Perera wrote:
> Hi Oleg
> > Apparently the limit value on the ByteArray instance is miscalculated
> > for some reason. At this moment I can't think of a cause leading to such
> > condition. So, a reproducer would be very help.
> >    
>          // subtract the length of the longest chunk header
>          // 12345678\r\n
>          avail -= 10;
> 
> Should the above be avail -= 12 since we need to terminate the chunk 
> with another \r\n ?
> 

You are right. Should be 12. This is not _that_ a major problem, though,
as this logic is intended to avoid unnecessary buffer expansion only.
Worst case, the buffer will have to expand in order to accommodate just
2 bytes. Should be fixed, though, no discussion.

Oleg

> cheers
> asankha
> 



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message