hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michajlo Matijkiw (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCLIENT-1001) CacheEntryUpdater does not properly update cache entry resource
Date Thu, 30 Sep 2010 15:43:33 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Michajlo Matijkiw updated HTTPCLIENT-1001:
------------------------------------------

    Attachment: cache_update_fix2.patch

This patch provides a slightly cleaner fix. 

 - Only 304 responses go through updateCacheEntry, and I have updated CacheEntryUpdater#updateCacheEntry()
to reinforce this
 - In CachingHttpClient#revalidateCacheEntry() non-304 responses go through handleBackendResponse()
to ensure cachability
 - Updated unit tests to reflect this change

I also fixed a random typo in CachedResponseSuitabilityChecker.java

Please let me know if I have missed anything.

This patch is submitted with the permission of my employer.

Thanks,
Michajlo

> CacheEntryUpdater does not properly update cache entry resource
> ---------------------------------------------------------------
>
>                 Key: HTTPCLIENT-1001
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-1001
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: Cache
>            Reporter: Michajlo Matijkiw
>             Fix For: 4.1 Alpha3
>
>         Attachments: cache_entry_updater_bug_test.patch, cache_update_fix.patch, cache_update_fix2.patch
>
>
> CacheEntryUpdater#updateCacheEntry() copies the old cache entry's resource, though I
believe it should only do so if the response is a 304.  Otherwise it should take the response
from the server to update the entry.  This method gets called when validating a cache entry
and the server returns a 200 or 304.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message