hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-989) DefaultHttpRequestRetryHandler must not retry non-idempotent http methods (violates RFC 2616)
Date Wed, 08 Sep 2010 20:34:32 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12907414#action_12907414

Oleg Kalnichevski commented on HTTPCLIENT-989:

I personally think that logging in DefaultRequestDirector is sufficient, but do feel free
to contribute a patch with proposed changes.


> DefaultHttpRequestRetryHandler must not retry non-idempotent http methods (violates RFC
> ---------------------------------------------------------------------------------------------
>                 Key: HTTPCLIENT-989
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-989
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0.1, 4.1 Alpha2
>            Reporter: Sylvain Laurent
>             Fix For: 4.1 Alpha3
> In DefaultHttpRequestRetryHandler, in case of NoHttpResponseException, the request is
retried, without taking into account whether the http method is idempotent or not. This violates
RFC 2616 section 8.1.4 which states :
> {quote}
> This means that clients, servers, and proxies MUST be able to recover
>    from asynchronous close events. Client software SHOULD reopen the
>    transport connection and retransmit the aborted sequence of requests
>    without user interaction so long as the request sequence is
>    idempotent (see section 9.1.2). Non-idempotent methods or sequences
>    MUST NOT be automatically retried, although user agents MAY offer a
>    human operator the choice of retrying the request(s).
> {quote}
> The fix is simple : at line 94, just remove the {{if (exception instanceof NoHttpResponseException)
}} block. This way the idempotency of the method will be taken into account a bit further
in the same method.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message