Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Message-ID: <31999481.177171280997856857.JavaMail.jira@thor>
Date: Thu, 5 Aug 2010 04:44:16 -0400 (EDT)
From: "Oleg Kalnichevski (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Subject: [jira] Commented: (HTTPCLIENT-974) RequestWrapper does not use the
 headers of the request it wraps.
In-Reply-To: <6541086.162481280946079816.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12895617#action_12895617 ] 

Oleg Kalnichevski commented on HTTPCLIENT-974:
----------------------------------------------

You are satisfied with the resolution, please go ahead and close the issue. 

By the way, you may want to take a look at the HttpRedirectStrategy in HttpClient 4.1 which should make handling of POST redirects easier.

Oleg 

> RequestWrapper does not use the headers of the request it wraps.
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-974
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-974
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.0.1
>            Reporter: Vianney Carel
>            Priority: Trivial
>             Fix For: 4.1 Alpha3
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> The RequestWrapper does not use the headers of the request it wraps. Therefore the wrapper appears as having no header, while the wrapped request may have some.
> To work-around that behavior, I have to call resetHeaders() on the wrapper just after having created it.
> This method does the following:
>     public void resetHeaders()
>     {
>         headergroup.clear();
>         setHeaders(original.getAllHeaders());
>     }
> I suggest calling setHeaders directly in the constructor. Or at least highlight in the Javadoc that we should call resetHeaders().

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org