hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michajlo Matijkiw (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCLIENT-978) provide an ehcache implementation for HttpCache
Date Thu, 19 Aug 2010 20:20:16 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-978?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel

Michajlo Matijkiw updated HTTPCLIENT-978:

    Attachment: ehcache_w_serialization3.patch

This patch includes the following changes:
  - Bought up to date to reflect Jonathan Moore's recent reorganization patch
  - Reintroduction of HttpCacheEntrySerializer interface, and reintroduction/reworking of
  - Fixed TestEhcacheProtocolRequirements name Protcol/Protocol typo, the mispelled version
should be deleted if it still exists
  - Updated TestEhcacheHttpCache tests- added testCacheGetNullEntry, testCacheUpdateNullEntry,
and testCacheUpdate 
  - Fixed update bug

Some notes:
  - DefaultCacheEntrySerializer makes the assumption that the underlying Set implementation
used to hold variants is serializable, I feel like this is a pretty safe assumption
  - It might be better practice to create a wrapper object as in intermediary for serialization
in DefaultCacheEntrySerializer, but the current version should only be a temporary fix until
the new httpcore is released, then we will be able to serialize HttpCacheEntry directly
  - Should TestEhcacheHttpCache be renamed to TestEhcacheHttpCacheStorage?  I can update the
patch to include this, but I thought it might be easier to do on your end after the problems
with the Protcol/Protocol typo.

Adding HttpCacheOperationException for failed updates is turning out to be a little more involved
than I had expected, so I was planning on adding this in a later patch.

Please let me know if there's anything else you would like me to include or change.

This patch is submitted with the permission of my employer.

Thank you,

> provide an ehcache implementation for HttpCache
> -----------------------------------------------
>                 Key: HTTPCLIENT-978
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-978
>             Project: HttpComponents HttpClient
>          Issue Type: New Feature
>          Components: Cache
>            Reporter: Jonathan Moore
>             Fix For: 4.1 Alpha3
>         Attachments: ehcache_w_serialization.patch, ehcache_w_serialization3.patch, httpclient-cache_ehcache-patch.patch,
> Provide an implementation of the HttpCache interface that stores cache entries in ehcache.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message