hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mingfai Ma (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCLIENT-970) Support underscore in domain/host name and don't throw exception
Date Tue, 27 Jul 2010 15:38:16 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mingfai Ma updated HTTPCLIENT-970:
----------------------------------

    Attachment: HTTPCLIENT-970.patch

didn't add any test case but i've built with the trunk version and can make connection to
an Internet host with underscore in the hostname.

> Support underscore in domain/host name and don't throw exception
> ----------------------------------------------------------------
>
>                 Key: HTTPCLIENT-970
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-970
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 4.1 Alpha2
>            Reporter: Mingfai Ma
>            Priority: Minor
>         Attachments: HTTPCLIENT-970.patch
>
>
> Trying to re-open HTTPCLIENT-911 
> could we use a custom logic to determine host instead of relying on URI.getHost() in
AbstractHttpClient.determineTarget? I propose to code it like this:
> {code}
> public abstract class AbstractHttpClient implements HttpClient {
>    ...
>     private HttpHost determineTarget(HttpUriRequest request) throws ClientProtocolException
{
>         // A null target may be acceptable if there is a default target.
>         // Otherwise, the null target is detected in the director.
>         HttpHost target = null;
>         URI requestURI = request.getURI();
>         if (requestURI.isAbsolute()) {
>             String ssp = requestURI.getSchemeSpecificPart();
>             ssp = ssp.substring(2, ssp.length()); //remove "//" prefix
>             int end = ssp.indexOf(':') > 0 ? ssp.indexOf(':') : 
>                     ssp.indexOf('/') > 0 ? ssp.indexOf('/') : 
>                     ssp.indexOf('?') > 0 ? ssp.indexOf('?') : ssp.length();
>             String host = ssp.substring(0, end);
>       ...
> {code}
> The logic basically to look for ':', '/', or '?' to determine the end index of the host.
The following test cases show how it works in different URL:
> {code}
>   @Test void testGetHostName1(){
>     String ssp = new URI("http://local_host").getSchemeSpecificPart();
>     ssp = ssp.substring(2, ssp.length()); //remove "//" prefix
>     int end = ssp.indexOf(':') > 0 ? ssp.indexOf(':') : ssp.indexOf('/') > 0 ?
ssp.indexOf('/') : ssp.indexOf('?') > 0 ? ssp.indexOf('?') : ssp.length();
>     assertEquals("local_host", ssp.substring(0, end));
>   }
>   @Test void testGetHostName2(){
>     String ssp = new URI("http://local_host:8080/").getSchemeSpecificPart();
>     ssp = ssp.substring(2, ssp.length()); //remove "//" prefix
>     int end = ssp.indexOf(':') > 0 ? ssp.indexOf(':') : ssp.indexOf('/') > 0 ?
ssp.indexOf('/') : ssp.indexOf('?') > 0 ? ssp.indexOf('?') : ssp.length();
>     assertEquals("local_host", ssp.substring(0, end));
>   }
>   @Test void testGetHostName3(){
>     String ssp = new URI("http://local_host/directory").getSchemeSpecificPart();
>     ssp = ssp.substring(2, ssp.length()); //remove "//" prefix
>     int end = ssp.indexOf(':') > 0 ? ssp.indexOf(':') : ssp.indexOf('/') > 0 ?
ssp.indexOf('/') : ssp.indexOf('?') > 0 ? ssp.indexOf('?') : ssp.length();
>     assertEquals("local_host", ssp.substring(0, end));
>   }
>   @Test void testGetHostName4(){
>     String ssp = new URI("http://local_host?k=v").getSchemeSpecificPart();
>     ssp = ssp.substring(2, ssp.length()); //remove "//" prefix
>     int end = ssp.indexOf(':') > 0 ? ssp.indexOf(':') : ssp.indexOf('/') > 0 ?
ssp.indexOf('/') : ssp.indexOf('?') > 0 ? ssp.indexOf('?') : ssp.length();
>     assertEquals("local_host", ssp.substring(0, end));
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message