hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jonathan Moore (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-972) caching module should use HttpParams-style configuration
Date Wed, 28 Jul 2010 17:07:18 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12893251#action_12893251
] 

Jonathan Moore commented on HTTPCLIENT-972:
-------------------------------------------

I'm fine with a simple beans-style configuration for the Cache; I just tried to copy what
was already in other parts of the codebase. :) 

I'm assuming something like a CacheParams class that starts with default settings, plus getters
and setters, and then passing those as the constructor args where needed instead of HttpParams?

I can take a shot at a patch for that.


> caching module should use HttpParams-style configuration
> --------------------------------------------------------
>
>                 Key: HTTPCLIENT-972
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-972
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: Cache
>    Affects Versions: 4.1 Alpha2
>            Reporter: Jonathan Moore
>            Priority: Minor
>         Attachments: cache-params.patch
>
>
> The constructor for CachingHttpClient currently accepts combinations of:
> * HttpCache
> * HttpClient
> * integer for max object size in bytes
> As I started looking at being able to configure this for behaving as a non-shared cache,
I realized that we actually want to be replacing that last int with an HttpParams argument,
and tracking all the various options in that style. I have a patch with this update which
I will upload shortly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message