hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-969) BasicCookieStore.getCookies() returns non-threadsafe collection
Date Wed, 21 Jul 2010 09:37:50 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890632#action_12890632
] 

Oleg Kalnichevski commented on HTTPCLIENT-969:
----------------------------------------------

TreeSet might indeed be a better underlying data structure for this class. I do not see much
of a problem with synchronisation on class methods, though. 

Anyway, we happily accept patches.

Oleg

> BasicCookieStore.getCookies() returns non-threadsafe collection
> ---------------------------------------------------------------
>
>                 Key: HTTPCLIENT-969
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-969
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>            Reporter: David Smiley
>            Priority: Minor
>             Fix For: 4.0.2, 4.1 Alpha3
>
>
> BasicCookieStore.getCookies() is a simple method.  It's synchronized, and it returns
an unmodifiable wrapper around the underlying cookie list.  If the caller were to then iterate
over it as another thread were to manipulate the cookie list via BasicCookieStore, this would
create a thread un-safe situation because both threads aren't doing their reading/writing
with the same lock (the reader doesn't even have a lock).
> I suggest fixing this by using CopyOnWriteArrayList, or by making a defensive copy in
getCookies()
> This issue might apply to some of the other basic implementations of some of the interfaces
but I haven't checked.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message