hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Rename mockup.TestHttpClient/Server test classes in httpcore/nio?
Date Mon, 14 Jun 2010 10:19:41 GMT
On 14/06/2010, Oleg Kalnichevski <olegk@apache.org> wrote:
> On Mon, 2010-06-14 at 00:39 +0100, sebb wrote:
>  > The mockup.TestHttpClient/Server/SSLClient/SSLServer classes in the
>  > httpcore-nio test tree don't currently contain any tests.
>  >
>  > This means that they fail when used with JUnit 4.
>  >
>  > It's also a bit confusing to have files called Test*.java that aren't
>  > actually tests.
>  >
>  > Similarly for the files mockup.TestHttpClient/Server in httpcore.
>  >
>  > Would it be OK to rename these classes? I think one could just drop
>  > the "Test" prefix.
>  >
>
>
> Several test cases fail now.

Sorry, my fault. I changed to JUnit4 for the whole of httpcore.

>  We simply have no other choice but rename the affected classes.

Well, we could have added excludes (as I did originally with
httpcore/httpcore), but that is messy and can be error prone.

>   Feel free to come up with new names you find most appropriate.

Thanks, now done.

>  Cheers
>
>  Oleg
>
>  Tests in error:
>   initializationError(org.apache.http.mockup.TestHttpSSLServer)
>   initializationError(org.apache.http.mockup.TestHttpSSLServer)
>   initializationError(org.apache.http.mockup.TestHttpSSLClient)
>   initializationError(org.apache.http.mockup.TestHttpSSLClient)
>   initializationError(org.apache.http.mockup.TestHttpClientNio)
>   initializationError(org.apache.http.mockup.TestHttpClientNio)
>   initializationError(org.apache.http.nio.protocol.TestJob)
>   initializationError(org.apache.http.mockup.TestHttpServerNio)
>   initializationError(org.apache.http.mockup.TestHttpServerNio)
>   initializationError(org.apache.http.nio.protocol.TestRequestHandler)
>   initializationError(org.apache.http.nio.protocol.TestRequestHandler)
>
>
>
>
>  ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>  For additional commands, e-mail: dev-help@hc.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message