hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-427) Implement a cache to perform real request only when needed
Date Mon, 03 May 2010 19:43:57 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12863488#action_12863488

Oleg Kalnichevski commented on HTTPCLIENT-427:


Only threading issue is a show stopper. All others can be addressed at a later point and should
not block the release. 

In my opinion the best way to ensure CacheEntity thread safety is by making it immutable.
Basically instead of updating an exiting entry the cache should replace an existing entry
with a new one thus making synchronisation on that entity unnecessary. This solves threading
issue without decreasing performance.   

I already have started working on a patch but was unable to fix 5 test cases that currently
fail. I will do my best to finish my changes tomorrow and pass it onto you for review. 

I have stumbled upon one particular bit which I cannot fully understand without your help.
What is the intent of variantURIs set? I could not figure out just by looking at the test


> Implement a cache to perform real request only when needed
> ----------------------------------------------------------
>                 Key: HTTPCLIENT-427
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-427
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>          Components: HttpClient
>         Environment: Operating System: Linux
> Platform: PC
>            Reporter: Marc Guillemot
>             Fix For: 4.1 Alpha2
>         Attachments: caching_client.zip, httpclient-cache.zip
> Browsers may cache received content according to the values of different
> response headers. It would be great if HttpClient could do the same.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org

View raw message