Return-Path: Delivered-To: apmail-hc-dev-archive@www.apache.org Received: (qmail 54344 invoked from network); 8 Apr 2010 13:50:59 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 8 Apr 2010 13:50:59 -0000 Received: (qmail 67892 invoked by uid 500); 8 Apr 2010 13:50:59 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 67828 invoked by uid 500); 8 Apr 2010 13:50:59 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 67485 invoked by uid 99); 8 Apr 2010 13:50:58 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Apr 2010 13:50:58 +0000 X-ASF-Spam-Status: No, hits=-1248.1 required=10.0 tests=ALL_TRUSTED,AWL X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Apr 2010 13:50:56 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id DAF0A234C4AE for ; Thu, 8 Apr 2010 13:50:36 +0000 (UTC) Message-ID: <1287516310.12181270734636894.JavaMail.jira@brutus.apache.org> Date: Thu, 8 Apr 2010 13:50:36 +0000 (UTC) From: "Oleg Kalnichevski (JIRA)" To: dev@hc.apache.org Subject: [jira] Resolved: (HTTPCLIENT-927) "Narrowly avoided an infinite loop in execute" should not be logged as an error. In-Reply-To: <1560181929.493491269541167286.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Oleg Kalnichevski resolved HTTPCLIENT-927. ------------------------------------------ Resolution: Won't Fix > "Narrowly avoided an infinite loop in execute" should not be logged as an error. > -------------------------------------------------------------------------------- > > Key: HTTPCLIENT-927 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-927 > Project: HttpComponents HttpClient > Issue Type: Improvement > Components: HttpClient > Affects Versions: 3.1 Final > Reporter: Qin Zang > > In the executeMethod(), upon received the "Redirect" as the HTTP Response Code, the code will log an error if the maxRedirects was set to 0 as in the following code. This is not an error, if someone want to stop the automatic redirect behavior. It should be logged as a warning or debug message. > 178 if (isRedirectNeeded(method)) { > 179 if (processRedirectResponse(method)) { > 180 retry = true; > 181 ++redirectCount; > 182 if (redirectCount >= maxRedirects) { > 183 LOG.error("Narrowly avoided an infinite loop in execute"); > 184 throw new RedirectException("Maximum redirects (" > 185 + maxRedirects + ") exceeded"); > 186 } > 187 if (LOG.isDebugEnabled()) { > 188 LOG.debug("Execute redirect " + redirectCount + " of " + maxRedirects); > 189 } > 190 } > 191 } -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org