hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Created: (HTTPCORE-223) Thread-safety improvements
Date Mon, 22 Mar 2010 23:01:28 GMT
Thread-safety improvements
--------------------------

                 Key: HTTPCORE-223
                 URL: https://issues.apache.org/jira/browse/HTTPCORE-223
             Project: HttpComponents HttpCore
          Issue Type: Improvement
          Components: HttpCore
            Reporter: Sebb
             Fix For: Future
         Attachments: threadsafety.patch

Thread-safety / isolation improvements to be considered for version 5.0
========================================================

AbstractHttpEntity
has 3 protected fields, however there are public getters/setters for
all of the fields, so it seems to me that the fields should be
private. That would allow synch. to be added later if necessary.

HttpEntityWrapper
- wrappedEntity should be final.

AbstractHttpMessage
- headerGroup should be final
- params should be private

BasicHttpProcessor
requestInterceptors and responseInterceptors should be final
Should also be private, otherwise subclasses can subvert the non-null condition

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message