Return-Path: Delivered-To: apmail-hc-dev-archive@www.apache.org Received: (qmail 83134 invoked from network); 15 Jan 2010 01:25:16 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 15 Jan 2010 01:25:16 -0000 Received: (qmail 96897 invoked by uid 500); 15 Jan 2010 01:25:15 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 96823 invoked by uid 500); 15 Jan 2010 01:25:15 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 96808 invoked by uid 99); 15 Jan 2010 01:25:15 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2010 01:25:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 15 Jan 2010 01:25:14 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 6855E234C1E9 for ; Thu, 14 Jan 2010 17:24:54 -0800 (PST) Message-ID: <1285767316.253501263518694426.JavaMail.jira@brutus.apache.org> Date: Fri, 15 Jan 2010 01:24:54 +0000 (UTC) From: "Tony Poppleton (JIRA)" To: dev@hc.apache.org Subject: [jira] Updated: (HTTPCLIENT-906) Minor performance improvement to IdleConnectionHandler In-Reply-To: <2011060433.253481263518574459.JavaMail.jira@brutus.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HTTPCLIENT-906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tony Poppleton updated HTTPCLIENT-906: -------------------------------------- Attachment: IdleConnectionHandler.java.patch > Minor performance improvement to IdleConnectionHandler > ------------------------------------------------------ > > Key: HTTPCLIENT-906 > URL: https://issues.apache.org/jira/browse/HTTPCLIENT-906 > Project: HttpComponents HttpClient > Issue Type: Improvement > Reporter: Tony Poppleton > Priority: Minor > Attachments: IdleConnectionHandler.java.patch > > > The attached patch does the following changes to IdleConnectionHandler > - as it iterator over a map of connections, using a LinkedHashMap is a faster > - rather than using an iterator over the keyset and subsequently getting the values, an iterator over the entry set is used instead for efficiency (at least according to FindBugs) > Note that the patch contains other changes to make variables final where possible. This was done automatically by Eclipse, and can be removed if desired. However I see no harm in them, other than they affect more of the code than intended by the patch. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org