hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sam Berlin (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-904) HttpMime StringBody constructor throws specification unnecessarily declares UnsupportedEncodingException
Date Tue, 12 Jan 2010 16:15:54 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12799249#action_12799249
] 

Sam Berlin commented on HTTPCLIENT-904:
---------------------------------------

What about a compromise -- a factory method that doesn't throw:

  /** An alternate to new StringBody(CharSet) that doesn't throw an exception. */
  public static StringBody create(CharSet charSet) {
     try {
         return new StringBody(charSet);
     } catch(UnsupportedEncodingException uee) {        
         throw new RuntimeException(uee); // this should never happen
     }
 }

There's precedent in the URI class.  The URI constructor throws, and there's a factory URI.create
method that doesn't declare the throwable.

> HttpMime StringBody constructor throws specification unnecessarily declares UnsupportedEncodingException
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-904
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-904
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpMime
>    Affects Versions: 4.0.1
>            Reporter: Mark Sinke
>
> The string body constructors that take a charset unnecessarily throw UnsupportedEncodingException
- if you have Charset, the encoding is by definition supported:
>     public StringBody(
>             final String text, 
>             final String mimeType, 
>             Charset charset) throws UnsupportedEncodingException {
>         super(mimeType);
>         if (text == null) {
>             throw new IllegalArgumentException("Text may not be null");
>         }
>         if (charset == null) {
>             charset = Charset.defaultCharset();
>         }
>         this.content = text.getBytes(charset.name());
>         this.charset = charset;
>     }
>     
>     public StringBody(final String text, Charset charset) throws UnsupportedEncodingException
{
>         this(text, "text/plain", charset);
>     }
>     
> I suggest to change this to
>     public StringBody(
>             final String text, 
>             final String mimeType, 
>             Charset charset)  {
>         super(mimeType);
>         if (text == null) {
>             throw new IllegalArgumentException("Text may not be null");
>         }
>         if (charset == null) {
>             charset = Charset.defaultCharset();
>         }
>         this.content = text.getBytes(charset);
>         this.charset = charset;
>     }
>     
>     public StringBody(final String text, Charset charset) {
>         this(text, "text/plain", charset);
>     }
> The important change is to change
>         this.content = text.getBytes(charset.name());
> to 
>         this.content = text.getBytes(charset);
> which will not throw and hence the throws specifications can be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message