hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sebb (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCLIENT-906) Minor performance improvement to IdleConnectionHandler
Date Fri, 15 Jan 2010 01:48:54 GMT

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12800498#action_12800498
] 

Sebb commented on HTTPCLIENT-906:
---------------------------------

Agree that using entry set is better if one wants both key and values.
Whether LHM is faster overall is less immediately obvious, and will depend on how the map
is used, not just how it is iterated.

The patch has spurious white-space changes as well as the final changes which make it very
much harder to review.
Also, when patches are committed it is generally prefereable to fix one problem per commit.
Please provide patches that fix only the problem at hand.

The original code for which you have provided a patch includes generics, which require Java
1.5+, so LinkedHashMap must be OK

> Minor performance improvement to IdleConnectionHandler
> ------------------------------------------------------
>
>                 Key: HTTPCLIENT-906
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-906
>             Project: HttpComponents HttpClient
>          Issue Type: Improvement
>            Reporter: Tony Poppleton
>            Priority: Minor
>         Attachments: IdleConnectionHandler.java.patch, IdleConnectionHandler.java.patch2
>
>
> The attached patch does the following changes to IdleConnectionHandler
>  - as it iterator over a map of connections, using a LinkedHashMap is a faster
>  - rather than using an iterator over the keyset and subsequently getting the values,
an iterator over the entry set is used instead for efficiency (at least according to FindBugs)
> Note that the patch contains other changes to make variables final where possible. This
was done automatically by Eclipse, and can be removed if desired. However I see no harm in
them, other than they affect more of the code than intended by the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message