hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-213) CharArrayBuffer.substring(int beginIndex, int endIndex) checks indexes unnecessarily
Date Sat, 16 Jan 2010 11:45:54 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12801148#action_12801148
] 

Oleg Kalnichevski commented on HTTPCORE-213:
--------------------------------------------

Good catch. Just remove the checks. 

Oleg

> CharArrayBuffer.substring(int beginIndex, int endIndex) checks indexes unnecessarily
> ------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-213
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-213
>             Project: HttpComponents HttpCore
>          Issue Type: Sub-task
>            Reporter: Sebb
>            Priority: Minor
>
> CharArrayBuffer.substring(int beginIndex, int endIndex) checks indexes before invoking
the String constructor, which also checks the indexes.
> String throws StringIndexOutOfBoundsException which is a subclass of IndexOutOfBoundsException.
> Code that catches IOOBE would also catch SIOOBE.
> If it was desired to maintain exact compatibilty then the exception could be caught and
transformed.
> But in any case the checks could be removed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message