hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tony Poppleton (JIRA)" <j...@apache.org>
Subject [jira] Created: (HTTPCLIENT-906) Minor performance improvement to IdleConnectionHandler
Date Fri, 15 Jan 2010 01:22:54 GMT
Minor performance improvement to IdleConnectionHandler
------------------------------------------------------

                 Key: HTTPCLIENT-906
                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-906
             Project: HttpComponents HttpClient
          Issue Type: Improvement
            Reporter: Tony Poppleton
            Priority: Minor


The attached patch does the following changes to IdleConnectionHandler
 - as it iterator over a map of connections, using a LinkedHashMap is a faster
 - rather than using an iterator over the keyset and subsequently getting the values, an iterator
over the entry set is used instead for efficiency (at least according to FindBugs)

Note that the patch contains other changes to make variables final where possible. This was
done automatically by Eclipse, and can be removed if desired. However I see no harm in them,
other than they affect more of the code than intended by the patch.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message