Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Message-ID: <1187758393.1257345092382.JavaMail.jira@brutus>
Date: Wed, 4 Nov 2009 14:31:32 +0000 (UTC)
From: =?utf-8?Q?Ortwin_Gl=C3=BCck_=28JIRA=29?= <jira@apache.org>
To: dev@hc.apache.org
Subject: [jira] Commented: (HTTPCLIENT-886) Incorrect handling of
 NoHttpResponseException in DefaultHttpMethodRetryHandler
In-Reply-To: <739382851.1257338972954.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-886?page=3Dcom.atlas=
sian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D=
12773493#action_12773493 ]=20

Ortwin Gl=C3=BCck commented on HTTPCLIENT-886:
-----------------------------------------

NoHttpResponseException is only ever thrown (from readStatusLine()) after t=
he response has been sent. So the conditon would never be true, actually. C=
an we think of ANY scenario where retrying is the right thing to do when we=
 get no response from the server?

> Incorrect handling of NoHttpResponseException in DefaultHttpMethodRetryHa=
ndler
> -------------------------------------------------------------------------=
-----
>
>                 Key: HTTPCLIENT-886
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-886
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 3.1 Final
>            Reporter: Sylvain Laurent
>
> We have a buggy load-balancer that sometimes forwards the request to the =
back-end server, and then close the connections without returning any data =
at all.
> This provokes a NoHttpResponseException inside commons http client 3.1, w=
hich is handled by DefaultHttpMethodRetryHandler.
> Unfortunately DefaultHttpMethodRetryHandler handles this NoHttpResponseEx=
ception by asking for a retry. In our case, this is very dangerous because =
the request has already been sent and is being processed by the back-end se=
rver.
> I think that in the case of a NoHttpResponseException the test !method.is=
RequestSent() shoud be done :
>         if (exception instanceof NoHttpResponseException && !method.isReq=
uestSent()) {
>             // Retry if the server dropped connection on us AND the reque=
st was not sent
>             return true;
>         }

--=20
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org