hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: Last redirect URL
Date Tue, 22 Sep 2009 14:43:18 GMT
On 22/09/2009, Oleg Kalnichevski <olegk@apache.org> wrote:
> On Tue, Sep 22, 2009 at 02:34:55PM +0100, sebb wrote:
>  > On 22/09/2009, Oleg Kalnichevski <olegk@apache.org> wrote:
>  > >
>
> > > Which would be wrong in my opinion since this behavior is not defined by the
>  > >  interface but rather is implementation specific. So, DefaultRequestDirector
>  > >  would be a more appropriate place but not the most obvious one.
>  >
>  > I've already updated getURI() - best treat that as a temporary experiment ...
>  >
>  > If that text is OK, it can be moved elsewhere, but given that the
>  > httpMethod#getURI() Javadoc leads back to HttpUriRequest, I think that
>  > there needs to be a pointer from there as well.
>  >
>  > Does getURI() behaviour vary between implementations?
>  > If so, this should definitely be mentioned in the interface Javadoc.
>  >
>
>
> Yes, it does, like that of many other methods. In some implementations the
>  request URI remains immutable, in others it can be changed. I certainly see
>  nothing that makes getURI() method so special.
>
>
>  > Or is it just that the implementations may handle redirect URIs differently?
>  >
>
>
> I thought the whole point of having an interface was to allow for
>  implementations with different behavior.
>

But the Javadoc needs to be clear what the contract for the method is.
IMO at present this is not clear.
This is especially true since it is a change from the behaviour in 3.1
(which is where we started).

>  > >
>  > >  So, I am leaning more towards adding a paragraph on HTTP request immutability
>  > >  to the tutorial, if it is not there already.
>  > >
>  > >  Oleg
>  > >
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>  For additional commands, e-mail: dev-help@hc.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message