hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Asankha C. Perera (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HTTPCORE-208) Pass the IOSession along with the Exception to the registered IOReactorExceptionHandler
Date Mon, 28 Sep 2009 11:47:16 GMT

    [ https://issues.apache.org/jira/browse/HTTPCORE-208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760220#action_12760220
] 

Asankha C. Perera commented on HTTPCORE-208:
--------------------------------------------

Hi Oleg

For (1) and (2) type errors, I think its always better to stop and restart the IO reactor.


For type (3) errors, I think its always better to close the session, and if the exception
handler is intended to handle these anyway, I thought it would be a nice way to allow the
user to handle them with the exception handler, than writing a bunch of try-catches in multiple
places of user code, as a try-catch already exits just above that which would call into the
exception handler anyway.

thanks
asankha

> Pass the IOSession along with the Exception to the registered IOReactorExceptionHandler
> ---------------------------------------------------------------------------------------
>
>                 Key: HTTPCORE-208
>                 URL: https://issues.apache.org/jira/browse/HTTPCORE-208
>             Project: HttpComponents HttpCore
>          Issue Type: Improvement
>    Affects Versions: 4.1-alpha1
>            Reporter: Asankha C. Perera
>            Assignee: Asankha C. Perera
>            Priority: Minor
>             Fix For: 4.1-beta1
>
>
> Currently an IOReactorExceptionHandler is only passed the exception encountered by the
reactor. The BaseIOReactor which ultimately calls the exception handler could pass the IOSession
to the exception handler. With this, the exception handlers down the line could be enhanced
to close the session/connection (if its not closed) or use the information for reporting purposes
etc, such as connection details for the failure.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message