Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Message-ID: <489544696.1250861295497.JavaMail.jira@brutus>
Date: Fri, 21 Aug 2009 06:28:15 -0700 (PDT)
From: "Sebb (JIRA)" <jira@apache.org>
To: dev@hc.apache.org
Subject: [jira] Commented: (HTTPCLIENT-866) HttpClient depends on
 jcip-annotations.jar
In-Reply-To: <1510228914.1250125034812.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HTTPCLIENT-866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12745964#action_12745964 ] 

Sebb commented on HTTPCLIENT-866:
---------------------------------

I've been thinking more about this - seems to me that if we use the annotations, then they should be used consistently, i.e. we should use them in HttpCore as well.

If we add annotations as part of HttpClient, then it may be hard to add them to HttpCore later without causing problems.
I think the annotations would need to go in a separate module, this might make it possible to move them to HttpCore later.

I'm beginning to think it might be easier to comment out the annotations for now.

> HttpClient depends on jcip-annotations.jar
> ------------------------------------------
>
>                 Key: HTTPCLIENT-866
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-866
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>    Affects Versions: 4.0 Final
>         Environment: javac 1.5.0_19
>            Reporter: David Nault
>            Priority: Critical
>         Attachments: HTTPCLIENT-866.patch
>
>
> When using Java 5 to compile code that uses HttpClient, jcip-annotations.jar must be in the classpath or else you get a compiler error:
>     [javac] /path/to/src/SomeFile.java:129: cannot access net.jcip.annotations.GuardedBy
>     [javac] file net/jcip/annotations/GuardedBy.class not found
>     [javac]         DefaultHttpClient httpclient = new DefaultHttpClient();
>     [javac]                                        ^
> With Java 6, you get a bunch of warnings instead.
>     [javac] org/apache/http/impl/client/AbstractHttpClient.class(org/apache/http/impl/client:AbstractHttpClient.class): warning: Cannot find annotation method 'value()' in type 'net.jcip.annotations.GuardedBy': class file for net.jcip.annotations.GuardedBy not found
> This requirement doesn't seem to be documented anywhere, and jcip-annotations.jar is not included in the "httpcomponents-client-4.0-bin-with-dependencies" package.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org