Return-Path: Delivered-To: apmail-hc-dev-archive@www.apache.org Received: (qmail 60411 invoked from network); 18 Mar 2009 14:32:40 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.2) by minotaur.apache.org with SMTP; 18 Mar 2009 14:32:40 -0000 Received: (qmail 17219 invoked by uid 500); 18 Mar 2009 14:32:39 -0000 Delivered-To: apmail-hc-dev-archive@hc.apache.org Received: (qmail 17194 invoked by uid 500); 18 Mar 2009 14:32:39 -0000 Mailing-List: contact dev-help@hc.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "HttpComponents Project" Delivered-To: mailing list dev@hc.apache.org Received: (qmail 17183 invoked by uid 99); 18 Mar 2009 14:32:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2009 07:32:39 -0700 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [64.22.71.118] (HELO server.embody.org) (64.22.71.118) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 18 Mar 2009 14:32:30 +0000 Received: from home.embody.org (71-92-211-124.static.mtpk.ca.charter.com [71.92.211.124]) by server.embody.org (Postfix) with ESMTP id CAF8D463F4 for ; Wed, 18 Mar 2009 09:32:09 -0500 (EST) Received: by home.embody.org (Postfix, from userid 500) id 33B60708D5; Wed, 18 Mar 2009 07:32:09 -0700 (PDT) Date: Wed, 18 Mar 2009 07:32:09 -0700 From: Mike Dillon To: HttpComponents Project Subject: Re: JCIP annotations Message-ID: <20090318143208.GC22683@hygelac.int.embody.org> Mail-Followup-To: HttpComponents Project References: <25aac9fc0903172010v34e928e6xff49721e580f382@mail.gmail.com> <20090318032021.GA15548@hygelac.int.embody.org> <25aac9fc0903172101y259e551p79d4b9e62039954e@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <25aac9fc0903172101y259e551p79d4b9e62039954e@mail.gmail.com> User-Agent: Mutt/1.5.10i X-Virus-Checked: Checked by ClamAV on apache.org begin sebb quotation: > It didn't work when I tried it last. Admittedly that was a few months > ago, and there has just been a new release. But I just tried again > with the following code: > > import net.jcip.annotations.GuardedBy; > public class GuardedByTest { > @GuardedBy("this") > public int count; > public synchronized void incCount(){ > count++; > } > public int getCount(){ > return count; > } > } > > Which I would have expected to report some problems. I even tried > @GuardedBy("that") which IMO should also have triggered a warning. > > This was using the Eclipse plugin, 1.3.8.20090315. > > But perhaps I've missed something. I agree this should trigger a warning. I've forwarded your message to the Findbugs folks to find out what the deal is. -md --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org For additional commands, e-mail: dev-help@hc.apache.org