hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Oleg Kalnichevski (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HTTPCLIENT-824) Review the use of BaiscHttpParams and HttpProtocolProcessor in HttpClient
Date Fri, 06 Mar 2009 16:57:56 GMT

     [ https://issues.apache.org/jira/browse/HTTPCLIENT-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Oleg Kalnichevski updated HTTPCLIENT-824:
-----------------------------------------

    Fix Version/s:     (was: 4.0 Beta 3)
                   4.1.0

I reviewed the code and found the following:

(1) HttpClient correctly synchronizes access to its ProtocolProcessor instance variable. It
also makes a copy of it before passing it the request director, so the master copy can be
safely mutated while current requests are being executed. No problem here. 

(2) Things are a bit messy with HttpParams. BasicHttpParams classes is used all over the place.
Decorating those with a non-public thread-safe wrapper inside HttpClient does not really help
as the user can still mutate its state using the original reference. The problem can be solved
only by introducing a public thread-safe implementation of HttpParams, which we cannot do
until 4.1

Oleg

> Review the use of BaiscHttpParams and HttpProtocolProcessor in HttpClient
> -------------------------------------------------------------------------
>
>                 Key: HTTPCLIENT-824
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-824
>             Project: HttpComponents HttpClient
>          Issue Type: Task
>          Components: HttpClient
>            Reporter: Oleg Kalnichevski
>             Fix For: 4.1.0
>
>
> Review the use of BaiscHttpParams and HttpProtocolProcessor in HttpClient and replace
with thread-safe implementations where necessary.
> Oleg

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message