Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 74.125.78.145 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type:content-transfer-encoding;
        b=rZWvGKs7RDRlfFHnB9wHfiEwnmQtsp4sbnK5YCDh+2UPa1olYy725IX2+Ej1Rwdzvb
         rrWSIXvSL8BikPUmE9cNU6qCqg6XSWXlCHcDB2c04pdt8JsaMzUBAbtcRFAAB8fs8OdM
         DfhMDxOzEVUQQW/8JphqFtXi6NGJCEileYrN8=
MIME-Version: 1.0
In-Reply-To: <49982C4C.3040709@apache.org>
References: <25aac9fc0902150519h1199f8cdt1390135833357695@mail.gmail.com>
	 <49981B8E.1080600@apache.org>
	 <25aac9fc0902150618qd46cde5l102b00b7667fbad9@mail.gmail.com>
	 <25aac9fc0902150644y100bbd06j50f0a150a207a716@mail.gmail.com>
	 <49982C4C.3040709@apache.org>
Date: Sun, 15 Feb 2009 15:00:27 +0000
Message-ID: <25aac9fc0902150700k47dcae34l9c4920a20550ac3c@mail.gmail.com>
Subject: Re: Make BasicHttpProcessor Lists final?
From: sebb <sebbaz@gmail.com>
To: HttpComponents Project <dev@hc.apache.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

On 15/02/2009, Oleg Kalnichevski <olegk@apache.org> wrote:
> sebb wrote:
>
> > On 15/02/2009, sebb <sebbaz@gmail.com> wrote:
> >
> > > On 15/02/2009, Oleg Kalnichevski <olegk@apache.org> wrote:
> > >  > sebb wrote:
> > >
> >
>
>  ...
>
>
> > I've committed a fix.
> >
> > I'm not entirely sure about the behaviour of copyInterceptors() -
> > previously it would only update the target if the source was non-null.
> > I've changed this to check for size() > 0.
> >
> > However, this means that the target may not be the same as the source
> > - if the source has an empty List, the target List is left untouched.
> >
> > As far as I can tell, this is the same behaviour as before, but was
> > that behaviour correct?
> >
> >
>
>  This looks wrong.
>
>
> > It won't affect existing calls to the routine since they always pass
> > in a newly initialised target, whose lists will be empty. But if the
> > (protected) method is used directly, the behaviour may not be what is
> > suggested by the method name.
> >
> >
>
>  Let's fix it.

OK, I'll clear the target unconditionally.

BTW, I seem to have introduced a bug - or at least I've caused a test to fail:

testGracefulShutdown(org.apache.http.impl.nio.reactor.TestDefaultIOReactorsSSL)
 Time elapsed: 10.781 sec  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<0> but was:<10>

I'll look at that now.
>  Oleg
>
>
> ---------------------------------------------------------------------
>  To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
>  For additional commands, e-mail: dev-help@hc.apache.org
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org