hc-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Oleg Kalnichevski <ol...@apache.org>
Subject Re: Make BasicHttpProcessor Lists final?
Date Sun, 15 Feb 2009 13:41:34 GMT
sebb wrote:
> The BasicHttpProcessor has two Lists which are currently created on demand.
> 
> This results in a lot of checking to see if the lists exist.
> 
> Seems to me it would be better to always create the lists, and make them final.
> The class could be considerably simplified if this were done, and it
> would help with thread-safety.
> 
> Also, do the lists need to be protected, or could they be private?
> 
> At least if they are made final, subclasses cannot mess with them as much...
> 

Makes sense.

There is no good reason for those lists to be protected but reducing the 
visibility of those variables would may break binary compatibility with 
existing applications (however unlikely). Let's leave them protected.

Oleg

> S
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
> For additional commands, e-mail: dev-help@hc.apache.org
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


Mime
View raw message