Mailing-List: contact dev-help@hc.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "HttpComponents Project" <dev@hc.apache.org>
Received-SPF: neutral (athena.apache.org: local policy)
Subject: Re: BestMatchSpec - why does it not choose RFC2109?
From: Oleg Kalnichevski <olegk@apache.org>
To: HttpComponents Project <dev@hc.apache.org>
In-Reply-To: <25aac9fc0810260749nf019ee5qd43ab135c0d75d55@mail.gmail.com>
References: <25aac9fc0810251555o1209f547j78d263a385f2004@mail.gmail.com>
	 <1225017462.11216.11.camel@ubuntu> <1225023302.14954.2.camel@ubuntu>
	 <25aac9fc0810260622l609411abhd8a3155aac43a80e@mail.gmail.com>
	 <1225028136.15262.2.camel@ubuntu>
	 <25aac9fc0810260749nf019ee5qd43ab135c0d75d55@mail.gmail.com>
Content-Type: text/plain
Date: Sun, 26 Oct 2008 21:09:05 +0100
Message-Id: <1225051745.15262.7.camel@ubuntu>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit

On Sun, 2008-10-26 at 15:49 +0100, sebb wrote:
> On 26/10/2008, Oleg Kalnichevski <olegk@apache.org> wrote:
> > On Sun, 2008-10-26 at 14:22 +0100, sebb wrote:
> >  > On 26/10/2008, Oleg Kalnichevski <olegk@apache.org> wrote:
> >  > > On Sun, 2008-10-26 at 11:37 +0100, Oleg Kalnichevski wrote:
> >  > >  > On Sat, 2008-10-25 at 23:55 +0100, sebb wrote:
> >  > >
> >  > >
> >  > > Sebastian,
> >  > >
> >  > >  You were right. It seems the easiest and cleanest fix would be the make
> >  > >  best-match cookie spec pick up RFC2109 spec for cookies generated from
> >  > >  'Set-Cookie' headers.
> >  > >
> >  >
> >  > Agreed, and always use RFC2965 for Set-Cookie2 headers.
> >  >
> >  > The Set-Cookie header did not have a domain, so there may also be a
> >  > problem with the RFC2965 handling of a missing domain (it is optional,
> >  > just checked).
> >  >
> >  > The extracted cookie was set up with the domain "localhost", which of
> >  > course does not have the ".local" part attached. Same thing happened
> >  > when I used the actual local name for the host. Seems to me that
> >  > RFC2965 should add the ".local" suffix if necessary when generating
> >  > the missing domain.
> >  >
> >
> >
> > This sounds odd, because that is what it does. I could not reproduce the
> >  problem with a test case. Would you be able to put together a junit to
> >  reproduce the issue?
> >
> 
> I'll have a go later.
> 
> What I used was the Tomcat Cookie Example running locally combined
> with a modified ClientFormLogin example from HC SVN, but that's
> overkill for a test case.
> 
> Examples that failed are as follows:
> 
> <abcd=efgh>    Set-Cookie: special="abcd=efgh"; Version=1
> <abcd efgh>     Set-Cookie: special="abcd efgh"; Version=1
> 
> Ones that worked OK are:
> 
> <abcdefgh>      Set-Cookie: special=abcdefgh
> <"abcd efgh">  Set-Cookie: special="abcd efgh"
> 
> It's the ones that have a "Version" attribute that fail for me.
> 
> Note: the <> above are used to enclose the "cookievalue" parameter I
> used in the CookieExample form.
> 

Sebastian,

Bizarre. Could you please post a wire log / context log of that session?
This may be enough for me to figure out the cause of the problem.

Oleg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org